fix: copying and pasting procedure definitions#6747
Merged
BeksOmega merged 2 commits intoRaspberryPiFoundation:developfrom Jan 12, 2023
Merged
fix: copying and pasting procedure definitions#6747BeksOmega merged 2 commits intoRaspberryPiFoundation:developfrom
BeksOmega merged 2 commits intoRaspberryPiFoundation:developfrom
Conversation
BeksOmega
force-pushed
the
fix/procedure-copy-paste
branch
from
8c27dcd to
aae3736
Compare
gonfunko
approved these changes
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6749
Proposed Changes
Before when you would load two procedure definition blocks that point to the same procedure ID (e.g. when copy pasting) they would both be associated with the same procedure model, which is not what you want. This makes sure that each individual procedure definition block (excluding insertion markers) is associated with its own procedure model.
Test Coverage
Added a test for deserializing two procedure definition blocks that are both associated with the same procedure model.
Documentation
N/A
Additional Information
Dependent on #6746